[PATCH] Avoid using "common" macro names as goto labels

Jason Evans jasone at canonware.com
Tue Apr 10 15:09:55 PDT 2012

On Apr 10, 2012, at 12:47 PM, Mike Hommey wrote:
> On Tue, Apr 10, 2012 at 11:29:30AM -0700, Jason Evans wrote:
>> On Apr 10, 2012, at 6:11 AM, Mike Hommey wrote:
>>> From: Mike Hommey <mh at glandium.org>
>>> OUT and ERROR are defined under mingw.
>> This is a bit like treading a minefield.  I'm inclined to prefix all
>> labels with JEMALLOC_LABEL_ to make sure the issue doesn't come up
>> again.  What do you think?
> Another approach would be to use lowercase names. They'd be less likely
> to be defined as macros.

Good idea.  I just committed a change from FOO to label_foo.  Plain foo wouldn't have worked for RETURN.


More information about the jemalloc-discuss mailing list