[PATCH] Use a make variable instead of preprocessing for srcroot, and simplify source files handling

Mike Hommey mh+jemalloc at glandium.org
Mon Apr 16 13:22:43 PDT 2012


On Mon, Apr 16, 2012 at 12:28:16PM -0700, Jason Evans wrote:
> On Apr 12, 2012, at 8:14 AM, Mike Hommey wrote:
> > From: Mike Hommey <mh at glandium.org>
> > 
> > --- Makefile.in |   99
> > ++++++++++++++++++++++++++++++----------------------------- 1 file
> > changed, 50 insertions(+), 49 deletions(-)
> 
> I'm not keen on the objroot removal diff, conversion from @srcroot@ to
> $(srcroot), or the removal of paths relative to the top directory.  I
> see these all as style choices for which the existing choices are
> reasonable.  Unfortunately, a bunch of other diffs you sent this
> morning are based on this and the objroot removal diff, which makes
> them difficult to apply.

The diffs I sent today are independent of that patch, and just apply
from 1/7 to 7/7. "[PATCH 3/7] Use make variables instead of preprocessing"
from today, is kind of equivalent to the one you mention, except it
only replaces @*@ with $(*), which makes things much easier to work on.

Mike



More information about the jemalloc-discuss mailing list