[PATCH] Use a make variable instead of preprocessing for srcroot, and simplify source files handling

Jason Evans jasone at canonware.com
Mon Apr 16 23:07:23 PDT 2012

On Apr 16, 2012, at 2:42 PM, Jason Evans wrote:
> On Apr 16, 2012, at 1:22 PM, Mike Hommey wrote:
>> On Mon, Apr 16, 2012 at 12:28:16PM -0700, Jason Evans wrote:
>>> I'm not keen on the objroot removal diff, conversion from @srcroot@ to
>>> $(srcroot), or the removal of paths relative to the top directory.  I
>>> see these all as style choices for which the existing choices are
>>> reasonable.  Unfortunately, a bunch of other diffs you sent this
>>> morning are based on this and the objroot removal diff, which makes
>>> them difficult to apply.
>> The diffs I sent today are independent of that patch, and just apply
>> from 1/7 to 7/7. "[PATCH 3/7] Use make variables instead of preprocessing"
>> from today, is kind of equivalent to the one you mention, except it
>> only replaces @*@ with $(*), which makes things much easier to work on.
> Okay, thanks for the clarification.  I'll try to get the diffs committed this afternoon.

All applied now.  Good stuff.


More information about the jemalloc-discuss mailing list