[PATCH 6/7] Avoid using a union for ctl_node_s

Mike Hommey mh+jemalloc at glandium.org
Sun Apr 22 23:50:10 PDT 2012


On Sun, Apr 22, 2012 at 01:09:07AM -0700, Jason Evans wrote:
> On Apr 19, 2012, at 11:38 PM, Mike Hommey wrote:
> > From: Mike Hommey <mh at glandium.org>
> > 
> > MSVC doesn't support C99, and as such doesn't support designated
> > initialization of structs and unions. As there is never a mix of
> > indexed and named nodes, it is pretty straightforward to use a
> > different type for each.
> > ---
> > include/jemalloc/internal/ctl.h |   27 ++++---
> > src/ctl.c                       |  164 +++++++++++++++++++++++----------------
> > 2 files changed, 110 insertions(+), 81 deletions(-)
> 
> This patch causes crashes if MALLOC_CONF=stats_print:true is set.

I ran all the tests with MALLOC_CONF=stats_print:true and got no crash.
Do you have a testcase?

Mike



More information about the jemalloc-discuss mailing list