[PATCH 4/7] Use "hardcoded" dependencies instead of having the compiler generate them
mh+jemalloc at glandium.org
Mon Apr 30 22:29:43 PDT 2012
On Mon, Apr 30, 2012 at 06:17:32PM -0700, Jason Evans wrote:
> On Apr 30, 2012, at 3:38 AM, Mike Hommey wrote:
> > From: Mike Hommey <mh at glandium.org>
> > The main reason is that MSVC doesn't have flags to generate these
> > dependencies. It is possible to generate them with the output from
> > the showincludes flag, but it also requires to wrap the compiler,
> > and filter its output on a message that changes depending on the
> > system locale.
> > Considering all c files include jemalloc_internal.h, and that this
> > file includes all others headers, it's just simpler to set
> > dependencies in stone. The generated dependencies were all the same
> > anyways.
> I don't want to throw away the automatic dependency generation because
> it's, well, automatic. Can't the hard-coding be limited to MSVC
Do you have any plans of not including all headers from
jemalloc_internal.h? If not, then what's the point in automatic
dependency generation when you know the result already, and it's the
same for all files?
More information about the jemalloc-discuss