[PATCH] Add a SYS_write definition on systems where it is not defined in headers

Ricardo Nabinger Sanchez rnsanchez at wait4.org
Tue Mar 27 06:11:38 PDT 2012


Hello Mike,

On Tue, 27 Mar 2012 14:48:58 +0200
Mike Hommey <mh+jemalloc at glandium.org> wrote:

> +#if !defined(SYS_write) && defined(__NR_write)
> +#define SYS_write __NR_write
> +#endif

Isn't this a good spot for something like the following?

#else
#error "SYS_write is broken on your system."
#endif

Unless I'm overlooking something obvious, it should not be a good thing
letting the compilation go past this point, assuming it will fail in a
later stage anyway.

Cheers

-- 
Ricardo Nabinger Sanchez           http://rnsanchez.wait4.org/
  "Left to themselves, things tend to go from bad to worse."



More information about the jemalloc-discuss mailing list