[PATCH] Move __func__ to jemalloc_internal_macros.h

Mike Hommey mh+jemalloc at glandium.org
Wed May 21 02:42:27 PDT 2014

On Wed, May 21, 2014 at 06:06:14PM +0900, Mike Hommey wrote:
> From: Mike Hommey <mh at glandium.org>
> test/integration/aligned_alloc.c needs it.
> ---
>  include/jemalloc/internal/jemalloc_internal.h.in     | 1 -
>  include/jemalloc/internal/jemalloc_internal_macros.h | 4 ++++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> diff --git a/include/jemalloc/internal/jemalloc_internal.h.in b/include/jemalloc/internal/jemalloc_internal.h.in
> index c9462e5..d9bfadf 100644
> --- a/include/jemalloc/internal/jemalloc_internal.h.in
> +++ b/include/jemalloc/internal/jemalloc_internal.h.in
> @@ -46,7 +46,6 @@
>  typedef intptr_t ssize_t;

This (ssize_t) is also needed in another integration test. It seems
convoluted to move that in _macros.h.

Jason, how do you think I should handle this?

Relatedly, with the 10 patches I just sent (one of which is in the
moderation queue because the patch is big), I have two remaining
build failures on tests with MSVC:
- test/unit/math.c fails to build because of the lack of INFINITY.
 I haven't found a replacement definition that works in a const array.
- test/unit/mq.c fails to build because of the use of
  nanosleep/timespec. I haven't looked for a replacement yet.

As for running tests, the following unit tests crash:
- ckh
- rtree
- tsd

They all crash in malloc_tsd_malloc, which is fishy.

In integration tests, thread_arena, posix_memalign and aligned_alloc
fail with assertions. Haven't looked further.



More information about the jemalloc-discuss mailing list