[PATCH] Avoid NULL check in je_free

[Jason Evans]

On Apr 2, 2012, at 3:00 PM, Jason Evans wrote:
> On Apr 2, 2012, at 2:37 AM, Mike Hommey wrote:
>> From: Mike Hommey <mh at glandium.org>
>> 
>> The original patch from Igor Bukanov <igor at mir2.org>, in
>> https://bugzilla.mozilla.org/show_bug.cgi?id=571332, was also
>> modifying idalloc and arena_dalloc to avoid two CHUNK_ADDR2BASE
>> invocation, but since both functions are inlined, I doubt this
>> actually makes a difference.
>> ---
>> include/jemalloc/internal/jemalloc_internal.h.in |   10 +++-------
>> src/jemalloc.c                                   |   22 ++++++++++------------
>> 2 files changed, 13 insertions(+), 19 deletions(-)
> 
> Applied, with some tweaks and additional tests.
> 
> http://www.canonware.com/cgi-bin/gitweb.cgi?p=jemalloc.git;a=commitdiff;h=96d4120ac08db3f2d566e8e5c3bc134a24aa0afc
> 
> Unfortunately, I just realized that it introduces a bug due to overly strict assertions, but I'll get that fixed in a moment.

Actually, the patch is untenable because the thread_allocated_tsd_get() call in free() isn't safe until after initialization has occurred, and there's no cheaper way to assure initialized state than to check whether ptr is NULL.  Oh well.

Jason