[PATCH] Avoid using "common" macro names as goto labels

Mike Hommey mh+jemalloc at glandium.org
Tue Apr 10 12:47:09 PDT 2012


On Tue, Apr 10, 2012 at 11:29:30AM -0700, Jason Evans wrote:
> On Apr 10, 2012, at 6:11 AM, Mike Hommey wrote:
> > From: Mike Hommey <mh at glandium.org>
> > 
> > OUT and ERROR are defined under mingw.
> 
> This is a bit like treading a minefield.  I'm inclined to prefix all
> labels with JEMALLOC_LABEL_ to make sure the issue doesn't come up
> again.  What do you think?

Another approach would be to use lowercase names. They'd be less likely
to be defined as macros.

Mike



More information about the jemalloc-discuss mailing list