jemalloc win32 port

Mike Hommey mh+jemalloc at glandium.org
Sun Feb 19 01:55:13 PST 2012


On Sun, Feb 19, 2012 at 10:46:41AM +0200, Yoni Londner wrote:
> Hi Mike,
> 
> > - I don't see anything using your pseudo random generator, so you
> >  probably can just skip prn.h altogether.
> 
> You are right, but I think its better to change its name, so we an to use it in the future.
> It took me a while to understand why the tar.gz didn't open correctly on my machine, and I didn't want anyone else to spend time on this error.

Again, I'm not a jemalloc developer, but if i were, i'd avoid commits
changing too many things at the same time. If this is needed in the
future, it can be added then.
 
> > - It's confusing to mix porting changes and unrelated changes, like
> >  abort->xabort.
> 
> Again, you are right. I am porting jemalloc as part of a bigger
> project, and its hard to separate the changes.
> On the other hand, they are all good changes (I think), and they
> make jemalloc better.

Like above.

Mike



More information about the jemalloc-discuss mailing list