[PATCH] Move __func__ to jemalloc_internal_macros.h
jasone at canonware.com
Wed May 28 11:26:21 PDT 2014
On May 28, 2014, at 11:11 AM, Jason Evans <jasone at canonware.com> wrote:
> On May 27, 2014, at 8:38 PM, Mike Hommey <mh+jemalloc at glandium.org> wrote:
>> On Tue, May 27, 2014 at 04:10:39PM -0700, Jason Evans wrote:
>>>> As for running tests, the following unit tests crash:
>>>> - ckh
>>>> - rtree
>>>> - tsd
>>>> They all crash in malloc_tsd_malloc, which is fishy.
>>> Probably a bootstrapping order issue, but I don't have any concrete guesses as to how it's failing.
>> And it is. It is caused by those tests assuming that jemalloc is
>> initialized as a side effect of the constructor added in
>> 20f1fc95adb35ea63dc61f47f2b0ffbd37d39f32, which doesn't run on msvc
>> builds, and is not needed since there is no fork().
>> Do you think it's better to make jemalloc initialize itself on msvc
>> builds anyways, or to make those tests explicitely initialize jemalloc?
> I just made a small change to the test harness to address this:
> I'd rather initialization be automatic so that we don't run into this sort of test fragility in the future. Let me know if the diff doesn't do the right thing for some reason.
Avoid unintended side effects:
More information about the jemalloc-discuss