Removing macros in tsd.h

Jason Evans jasone at canonware.com
Tue Mar 3 21:58:31 PST 2015


On Mar 3, 2015, at 6:59 PM, Mike Hommey <mh at glandium.org> wrote:
> Today, as I was debugging an issue that led me to
> https://github.com/jemalloc/jemalloc/pull/198 I had this thought:
> 
> Ever since 5460aa6, there is only one use of malloc_tsd_funcs, if you
> don't count the one in the tsd unit test. I think the genericity of the
> tsd code through the use of macros is now outweighed by the fact that
> using macros make it essentially undebuggable.
> 
> How would you welcome a patch that unwraps all of tsd.h such that it
> doesn't use macros anymore?

As long as the tsd code is still testable, I'd consider such a patch a distinct improvement. =)

Thanks,
Jason


More information about the jemalloc-discuss mailing list